-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix watchFiles error with vite 5.3 #1312
Conversation
🦋 Changeset detectedLatest commit: 8978afd The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for houdinigraphql canceled.
|
✅ Deploy Preview for houdini-docs-next canceled.
|
Awesome, thanks for fixing it! When will it be released? |
Hopefully by the end of this week, I'm just bumping some versions in the repository, and I want it to be part to the next version as well. |
@macmillen and others: I just published the fix, it's up on v1.2.48 I wasn't able to bump the dependencies yet, as I'm getting some very strange errors when building. But the package is forwards compatible so everything should just work. |
Thank you! 🚀 |
Fixes #1306
Since the
addWatchFile
is context-aware, it ended up being invalid by the time the houdini plugins came around to use the function.This PR is a quick fix to ensure that people can keep using Houdini with the latest version of Vite.
We'll need to properly rewrite the Vite plugin at one point so that
this.addWatchFile
is only called from within the houdini vite plugin itself.For more context, take a look at the referenced issue, or this thread in Discord
To help everyone out, please make sure your PR does the following:
pnpm run tests
andcd integration && pnpm run tests
pnpm changeset